[Transform] optmize histogam group_by change detection #74031
Merged
+93
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
force-pushed
the
transform-optimize-histogram
branch
from
a519b38 to
38a31b9
Compare
...stTest/java/org/elasticsearch/xpack/transform/integration/continuous/HistogramGroupByIT.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/xpack/transform/transforms/pivot/CompositeBucketsChangeCollector.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/xpack/transform/transforms/pivot/CompositeBucketsChangeCollector.java
Show resolved
Hide resolved
| minAggregationOutputName = COMPOSITE_AGGREGATION_NAME + "." + targetFieldName + ".min"; | ||
| maxAggregationOutputName = COMPOSITE_AGGREGATION_NAME + "." + targetFieldName + ".max"; | ||
|
|
||
| // the time field for the date histogram is different than for sync |
There was a problem hiding this comment.
Sorry, I don't understand how does this comment relate to the surrounding code.
...java/org/elasticsearch/xpack/transform/transforms/pivot/CompositeBucketsChangeCollector.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement a simple change optimization for histograms using min and max aggregations. The optimization is not applied if the range cutoff would be too small compared to the overall range from previous checkpoints. At least 20% must be cut compared to former checkpoints.
fixes #63801
The histogram case is tough, depending on the meaning of the value. If the value is a metric value it might not make sense to optimize this case as the range might be spread across the full range for all checkpoints. If the number is a case or issue number, I think terms should be used.
The most common scenario I am aware of is a monotonic increasing sequence number generated externally. For this case, the optimization should yield good results. I kept it simple, the change collector only remembers values in memory, so the transform has to run some checkpoints until it kicks in.