Skip to content

Speed up Slow FlushIT #74013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

original-brownbear
Copy link
Contributor

This test regularly takes almost 10s because 5s default check interval
would cause a long wait until the idle check even runs. This in turn would
cause the busy assert to backoff to a long wait, causing this test to generally
hold up the build worker it runs on => shorter check interval.

This test regularly takes almost `10s` because 5s default check interval
would cause a long wait until the idle check even runs. This in turn would
cause the busy assert to backoff to a long wait, causing this test to generally
hold up the build worker it runs on => shorter check interval.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.14.0 labels Jun 10, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin!

@original-brownbear
Copy link
Contributor Author

np + thanks Nhat!

@original-brownbear original-brownbear merged commit de88280 into elastic:master Jun 10, 2021
@original-brownbear original-brownbear deleted the speed-up-slow-flush-it branch June 10, 2021 18:15
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jun 10, 2021
This test regularly takes almost `10s` because 5s default check interval
would cause a long wait until the idle check even runs. This in turn would
cause the busy assert to backoff to a long wait, causing this test to generally
hold up the build worker it runs on => shorter check interval.
original-brownbear added a commit that referenced this pull request Jun 13, 2021
This test regularly takes almost `10s` because 5s default check interval
would cause a long wait until the idle check even runs. This in turn would
cause the busy assert to backoff to a long wait, causing this test to generally
hold up the build worker it runs on => shorter check interval.
@original-brownbear original-brownbear restored the speed-up-slow-flush-it branch April 18, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants