Adjust get alias api for write data streams #73987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `is_write_index` instead of `is_write_data_stream` to indicate whether an data stream alias is a write data stream alias. Although the latter is a more accurate name, the former is what is used to turn a data stream alias into a write data stream in the indices aliases api. The design of data stream aliases is that it looks and behaves like any other alias and using `is_write_data_stream` would go against this design. Also index or indices is an accepted overloaded term that can mean both regular index, data stream or an alias in Elasticsearch APIs. By using `is_write_index`, consumers of the get aliases API don't need to make changes. Relates to elastic#66163
martijnvg
added
>non-issue
v8.0.0
:Data Management/Data streams
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@elasticmachine run elasticsearch-ci/part-1 |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jun 14, 2021
Backport elastic#73987 to 7.x branch. Use `is_write_index` instead of `is_write_data_stream` to indicate whether an data stream alias is a write data stream alias. Although the latter is a more accurate name, the former is what is used to turn a data stream alias into a write data stream in the indices aliases api. The design of data stream aliases is that it looks and behaves like any other alias and using `is_write_data_stream` would go against this design. Also index or indices is an accepted overloaded term that can mean both regular index, data stream or an alias in Elasticsearch APIs. By using `is_write_index`, consumers of the get aliases API don't need to make changes. Relates to elastic#66163
martijnvg
added a commit
that referenced
this pull request
Jun 14, 2021
Backport #73987 to 7.x branch. Use `is_write_index` instead of `is_write_data_stream` to indicate whether an data stream alias is a write data stream alias. Although the latter is a more accurate name, the former is what is used to turn a data stream alias into a write data stream in the indices aliases api. The design of data stream aliases is that it looks and behaves like any other alias and using `is_write_data_stream` would go against this design. Also index or indices is an accepted overloaded term that can mean both regular index, data stream or an alias in Elasticsearch APIs. By using `is_write_index`, consumers of the get aliases API don't need to make changes. Relates to #66163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
is_write_indexinstead ofis_write_data_streamto indicate whether an data stream aliasis a write data stream alias. Although the latter is a more accurate name, the former is what is
used to turn a data stream alias into a write data stream in the indices aliases api. The design
of data stream aliases is that it looks and behaves like any other alias and
using
is_write_data_streamwould go against this design.Also index or indices is an accepted overloaded term that can mean both regular index,
data stream or an alias in Elasticsearch APIs. By using
is_write_index, consumersof the get aliases API don't need to make changes.
Relates to #66163