Skip to content

[DOCS] Service account edits #73732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Jun 3, 2021

General edits for the service account docs, in addition to:

  • Putting all of the content on a single page to increase readability and enable users to search for content they want.
  • De-emphasizing the connection to built-in accounts. This comment from Tim was was lingering in my brain, and I do think it makes sense to decouple service accounts as an evolution of the built-in users. It's more of an implementation detail IMO.

Preview link: https://elasticsearch_73732.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/service-accounts.html

@lockewritesdocs lockewritesdocs added >docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.14.0 labels Jun 3, 2021
@lockewritesdocs lockewritesdocs self-assigned this Jun 3, 2021
@elasticmachine elasticmachine added Team:Security Meta label for security team Team:Docs Meta label for docs team labels Jun 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@lockewritesdocs lockewritesdocs requested a review from ywangd June 3, 2021 17:32
@lockewritesdocs
Copy link
Contributor Author

@elasticmachine update branch

@lockewritesdocs lockewritesdocs requested a review from tvernum June 10, 2021 14:36
@lockewritesdocs
Copy link
Contributor Author

@ywangd, thanks for your recent edits. I think that this information is ready for @tvernum to review.

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lockewritesdocs lockewritesdocs merged commit 5700903 into elastic:master Jun 15, 2021
@lockewritesdocs lockewritesdocs deleted the docs__service-account-edits branch June 15, 2021 13:11
lockewritesdocs pushed a commit that referenced this pull request Jun 15, 2021
* Put all service accounts information on one page

* De-emphasize connection with built-in accounts + edits

* Iterate on the docs: tweak, correction and more details.

* fix test

* Edits and minor text changes

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lockewritesdocs pushed a commit that referenced this pull request Jun 17, 2021
* Put all service accounts information on one page

* De-emphasize connection with built-in accounts + edits

* Iterate on the docs: tweak, correction and more details.

* fix test

* Edits and minor text changes

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Docs Meta label for docs team Team:Security Meta label for security team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants