Fix off-by-one in testDoesNotSubmitRerouteTaskTooFrequently #72313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reroute when the elapsed time is >= 60000ms, but the test assumes that no reroute happens exactly at 60000ms. This commit fixes this off-by-one-ms error. Relates elastic#60869 which introduced this test issue Relates elastic#68316 which mostly fixed this test issue except this one spot Closes elastic#71424
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
deleted the
2021-04-27-fix-testDoesNotSubmitRerouteTaskTooFrequently
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reroute when the elapsed time is >= 60000ms, but the test assumes
that no reroute happens exactly at 60000ms. This commit fixes this
off-by-one-ms error.
Relates #60869 which introduced this test issue
Relates #68316 which mostly fixed this test issue except this one spot
Closes #71424