Reenable SearchableSnapshotsRollingUpgradeIT #69788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks Yannick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test SearchableSnapshotsRollingUpgradeIT caused CI failures at least two times (#69705) since it was merged into master. After looking at all node logs, I wasn't able to determine precisely the cause of the test suite timeout.
After looking at the code I think it is preferable to use a dedicated path.repo for this test so that it does not interfere with existing and future tests that could wipe the repositories and snapshots of the default path.repo at any time. I also fixed an issue with the storage paramater that should only work starting 7.12.0. Finally, #69704 has been merged and it should provide more information if this test fails again.
Closes #69705