Fix test LdapSessionFactoryTests testSslTrustIsReloaded #69001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
changed the title
albertzaharovits
added
:Security/TLS
|
Pinging @elastic/es-security (Team:Security) |
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Feb 16, 2021
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes elastic#68995
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Feb 16, 2021
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes elastic#68995
albertzaharovits
added a commit
that referenced
this pull request
Feb 16, 2021
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes #68995
albertzaharovits
added a commit
that referenced
this pull request
Feb 16, 2021
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes #68995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LdapSessionFactoryTests#testSslTrustIsReloadedrelies on the resource watcher to detect the cert file overwriting.Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp.
For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type.
It is thus preferable to rely on file size differences in tests.
Closes #68995