Add max_single_primary_size as a condition for the ILM rollover action #68917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>enhancement
:Data Management/ILM+SLM
joegallo
force-pushed
the
ilm-rollover-max-single-shard-size
branch
2 times, most recently
from
f05b75a to
398d7c1
Compare
joegallo
force-pushed
the
ilm-rollover-max-single-shard-size
branch
from
398d7c1 to
66b94d3
Compare
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
IMHO reviewing commit by commit would be best, but that's just me. |
andreidan
reviewed
Feb 17, 2021
Comment on lines
75
to
+76
| this.maxSize = maxSize; | ||
| this.maxSinglePrimarySize = maxSinglePrimarySize; |
There was a problem hiding this comment.
would it make sense to validate that maxSinglePrimarySize is lte to maxSize?
There was a problem hiding this comment.
IMHO no -- we don't sanity check the other things (e.g. maxDocs 1 paired with maxSize 10,000GB is just as valid as maxDocs 10,000 with maxSize 1 byte -- at least AFAICT), so I think we should be similarly lenient with maxSinglePrimarySize.
...lti-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesLifecycleActionsIT.java
Outdated
Show resolved
Hide resolved
...lti-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesLifecycleActionsIT.java
Show resolved
Hide resolved
...lti-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesLifecycleActionsIT.java
Outdated
Show resolved
Hide resolved
...lti-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesLifecycleActionsIT.java
Show resolved
Hide resolved
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Feb 18, 2021
joegallo
added a commit
that referenced
this pull request
Feb 18, 2021
|
@elastic/es-ui there's a new option for ILM Rollovers (in 7.13 and 8.0.0). On this PR it was added as |
joegallo
added
the
Team:Deployment Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63026, followup to #67842
Threads the new
max_single_primary_sizerollover trigger from #67842 into ILM'sRolloverAction.