Centralize common code for footer checksum read in BaseSearchableSnapshotIndexInput class #68902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
changed the title
tlrx
requested review from
original-brownbear and
ywelsch
and removed request for
original-brownbear
ywelsch
approved these changes
Feb 15, 2021
| @Override | ||
| public final long length() { | ||
| return length; | ||
| } | ||
|
|
||
| protected final void readInternal(ByteBuffer b) throws IOException { |
|
Thanks Yannick |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Feb 16, 2021
…shotIndexInput class (elastic#68902) This commit factorizes in the BaseSearchableSnapshotIndexInput class some common code used to read the footer checksum of searchable snapshots IndexInput implementations. This change helps to maintain the code to read the footer checksum in one place and helps to enable this optimisation for DirectBlobContainerIndexInput. It also helps to assert the non-usage of the cache fetch async thread pool when reading from a index input in a single place. Finally, the index input unit tests have been adapted to account for the footer checksum read optimisation: they now generate a binary content that contains a valid footer checksum.
tlrx
added a commit
that referenced
this pull request
Feb 16, 2021
…shotIndexInput class (#68902) (#69015) This commit factorizes in the BaseSearchableSnapshotIndexInput class some common code used to read the footer checksum of searchable snapshots IndexInput implementations. This change helps to maintain the code to read the footer checksum in one place and helps to enable this optimisation for DirectBlobContainerIndexInput. It also helps to assert the non-usage of the cache fetch async thread pool when reading from a index input in a single place. Finally, the index input unit tests have been adapted to account for the footer checksum read optimisation: they now generate a binary content that contains a valid footer checksum. Backport of #68902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request factorizes in the BaseSearchableSnapshotIndexInput class some common code used to read the footer checksum of searchable snapshots
IndexInputimplementations.This change helps to maintain the code to read the footer checksum in one place and helps to enable this optimisation for
DirectBlobContainerIndexInput. It also helps to assert the non-usage of the cache fetch async thread pool when reading from a index input in a single place.Finally, the index input unit tests have been adapted to account for the footer checksum read optimisation: they now generate a binary content that contains a valid footer checksum.