Skip to content

Adjust the MaxSinglePrimarySizeCondition version and re-enable BWC #68553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ tasks.register("verifyVersions") {
* after the backport of the backcompat code is complete.
*/

boolean bwc_tests_enabled = false
String bwc_tests_disabled_issue = "https://github.com/elastic/elasticsearch/pull/68489" /* place a PR link here when committing bwc changes */
boolean bwc_tests_enabled = true
String bwc_tests_disabled_issue = "" /* place a PR link here when committing bwc changes */
/*
* FIPS 140-2 behavior was fixed in 7.11.0. Before that there is no way to run elasticsearch in a
* JVM that is properly configured to be in fips mode with BCFIPS. For now we need to disable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
"Rollover with max_single_primary_size condition":
- skip:
version: " - 7.99.99"
reason: max_single_primary_size condition was introduced in 8.0.0
version: " - 7.11.99"
reason: max_single_primary_size condition was introduced in 7.12.0

# create index with alias and replica
- do:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ public static MaxSinglePrimarySizeCondition fromXContent(XContentParser parser)

@Override
boolean includedInVersion(Version version) {
return version.onOrAfter(Version.V_8_0_0);
return version.onOrAfter(Version.V_7_12_0);
}
}