[7.x] Add max_single_primary_size as a condition for the rollover index API #68489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (Team:Core/Features) |
joegallo
commented
Feb 3, 2021
| } | ||
| } | ||
|
|
||
| // helper because java 8 doesn't have Optional.stream |
There was a problem hiding this comment.
I'm not enormously thrilled about this, but 🤷.
There was a problem hiding this comment.
We do what we can with Java 8, this looks reasonable though.
joegallo
commented
Feb 3, 2021
| --- | ||
| "Rollover with max_single_primary_size condition": | ||
| - skip: | ||
| version: " - 7.11.99" |
There was a problem hiding this comment.
Double check my brain on this one bit here -- is this the right version?
dakrone
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63026, backport of #67842