Tests for running composite under nested aggregation #68243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine update branch |
not-napoleon
added
:Analytics/Aggregations
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Apr 7, 2021
|
|
||
| @Override | ||
| protected IndexReader wrapDirectoryReader(DirectoryReader reader) throws IOException { | ||
| if (useNestedDirectoryWrapping) { |
There was a problem hiding this comment.
Could you check if the list is non-empty?
| @@ -87,6 +87,21 @@ | |||
| import static org.elasticsearch.search.aggregations.AggregationBuilders.nested; | |||
| import static org.hamcrest.Matchers.equalTo; | |||
|
|
|||
| /** | |||
| * Tests for the Nested aggregator. | |||
| * | |||
There was a problem hiding this comment.
<p>.
Silly javadoc, you are too html.
There was a problem hiding this comment.
Bad HTML. <p> != <br/>. But fine.
There was a problem hiding this comment.
? I mean, you could <p> the whole paragraph. I dunno. whatever works.
nik9000
approved these changes
Apr 8, 2021
| @@ -87,6 +87,21 @@ | |||
| import static org.elasticsearch.search.aggregations.AggregationBuilders.nested; | |||
| import static org.hamcrest.Matchers.equalTo; | |||
|
|
|||
| /** | |||
| * Tests for the Nested aggregator. | |||
| * | |||
There was a problem hiding this comment.
? I mean, you could <p> the whole paragraph. I dunno. whatever works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds REST layer and junit layer tests for running composite aggregation under nested aggregations. It also adds some REST tests for nested, since I was there and we don't have any right now.
This is related to #38863 but I want to merge these tests separately so I can verify the current behavior before that change.