-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Remove unregistered discovery settings from old docs #68093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaveCTurner
merged 1 commit into
elastic:7.6
from
DaveCTurner:2021-01-28-remove-discovery-settings-docs
Jan 28, 2021
Merged
Remove unregistered discovery settings from old docs #68093
DaveCTurner
merged 1 commit into
elastic:7.6
from
DaveCTurner:2021-01-28-remove-discovery-settings-docs
Jan 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (elastic#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
I'm not sure the PR checks are going to work on this, the 7.6 branch is probably too old for them. |
ywelsch
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO merge
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier: - `discovery.probe.connect_timeout` - `discovery.probe.handshake_timeout` This was addressed in 7.7 (#51304) but the docs for older versions suggest incorrectly that these settings are available. This commit removes the docs for these settings in the affected versions to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
>docs
General docs changes
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
v7.0.2
v7.1.2
v7.2.2
v7.3.3
v7.4.3
v7.5.3
v7.6.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following settings are not exposed to users in 7.6 and earlier:
discovery.probe.connect_timeout
discovery.probe.handshake_timeout
This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.