Skip to content

Remove unregistered discovery settings from old docs #68093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DaveCTurner
Copy link
Contributor

The following settings are not exposed to users in 7.6 and earlier:

  • discovery.probe.connect_timeout
  • discovery.probe.handshake_timeout

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.

The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (elastic#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
@DaveCTurner DaveCTurner added >bug >docs General docs changes :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v7.0.2 v7.1.2 v7.2.2 v7.3.3 v7.4.3 v7.5.3 v7.6.3 labels Jan 28, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Jan 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor Author

I'm not sure the PR checks are going to work on this, the 7.6 branch is probably too old for them.

@DaveCTurner DaveCTurner requested a review from ywelsch January 28, 2021 09:10
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO merge

@DaveCTurner DaveCTurner merged commit bd72f25 into elastic:7.6 Jan 28, 2021
@DaveCTurner DaveCTurner deleted the 2021-01-28-remove-discovery-settings-docs branch January 28, 2021 11:25
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The following settings are not exposed to users in 7.6 and earlier:

- `discovery.probe.connect_timeout`
- `discovery.probe.handshake_timeout`

This was addressed in 7.7 (#51304) but the docs for older versions
suggest incorrectly that these settings are available. This commit
removes the docs for these settings in the affected versions to avoid
confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.0.2 v7.1.2 v7.2.2 v7.3.3 v7.4.3 v7.5.3 v7.6.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants