Skip to content

Drop gateway.recover_after_nodes from default conf #68000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

The gateway.recover_after_nodes setting is one of the lucky few that
gets a mention in the default elasticsearch.yml config file. This
setting was deprecated in favour of gateway.recover_after_data_nodes
in #53646, but neither of these settings is really important enough to
warrant a place in the default config so this commit removes it.

The `gateway.recover_after_nodes` setting is one of the lucky few that
gets a mention in the default `elasticsearch.yml` config file. This
setting was deprecated in favour of `gateway.recover_after_data_nodes`
in elastic#53646, but neither of these settings is really important enough to
warrant a place in the default config so this commit removes it.
@DaveCTurner DaveCTurner added >enhancement :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.12.0 labels Jan 26, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner requested a review from ywelsch January 28, 2021 09:10
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 4c12384 into elastic:master Jan 28, 2021
@DaveCTurner DaveCTurner deleted the 2021-01-26-no-recover_after_nodes-in-default-config branch January 28, 2021 11:24
DaveCTurner added a commit that referenced this pull request Jan 28, 2021
The `gateway.recover_after_nodes` setting is one of the lucky few that
gets a mention in the default `elasticsearch.yml` config file. This
setting was deprecated in favour of `gateway.recover_after_data_nodes`
in #53646, but neither of these settings is really important enough to
warrant a place in the default config so this commit removes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants