Skip to content

Improve watcher cleanup logic #67554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

martijnvg
Copy link
Member

by waiting for all tasks to complete before deleting watcher history data stream.

Closes #66495

by waiting for all tasks to complete before deleting watcher history data stream.

Closes elastic#66495
@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :Data Management/Watcher v8.0.0 v7.12.0 labels Jan 15, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martijnvg for fixing this!

@probakowski
Copy link
Contributor

btw, I think this could be master only, we switched to data stream for watcher history only in 8.0

@martijnvg martijnvg removed the v7.12.0 label Jan 15, 2021
@martijnvg martijnvg merged commit 1c85599 into elastic:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Watcher Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ActivateWatchTests fails occasionally on master not able to delete index
4 participants