Early detection of circuit breaker exception in the coordinating node #67431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In # we added the support for the request circuit breaker in search coordinating nodes. Today the circuit breaker is strictly checked only when a partial or final reduce occurs. With this commit, we also check the circuit breaker strictly when a shard response is received and we cancel the request early if an exception is thrown at this point.
jimczi
added
>enhancement
:Search/Search
elasticmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-search (Team:Search) |
server/src/main/java/org/elasticsearch/action/search/QueryPhaseResultConsumer.java
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Jan 14, 2021
jimczi
removed
:Core/Infra/Circuit Breakers
jimczi
added a commit
that referenced
this pull request
Jan 15, 2021
…#67431) In #62884 we added the support for the request circuit breaker in search coordinating nodes. Today the circuit breaker is strictly checked only when a partial or final reduce occurs. With this commit, we also check the circuit breaker strictly when a shard response is received and we cancel the request early if an exception is thrown at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #62884 we added the support for the request circuit breaker in search coordinating nodes.
Today the circuit breaker is strictly checked only when a partial or final reduce occurs.
With this commit, we also check the circuit breaker strictly when a shard response
is received and we cancel the request early if an exception is thrown at this point.