Skip to content

Fix SearchableSnapshotActionIT #66698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

andreidan
Copy link
Contributor

This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by

    cannot delete snapshot during a restore in progress

This adds a wait step after the tests that polls the repository status
until there are no snapshots.

Fixes #66497

This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by
```
    cannot delete snapshot during a restore in progress
```

This adds a wait step after the tests that polls the repository status
until there are no snapshots.
@andreidan andreidan added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.12.0 v7.11.1 labels Dec 21, 2020
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@andreidan andreidan requested a review from jakelandis December 21, 2020 16:03
@andreidan
Copy link
Contributor Author

andreidan commented Dec 21, 2020

I believe a similar discrepancy between the RepositoryData and the cluster state SnapshotsInProgress view over the snapshots is being addressed here I'm not aware of any similar work targeting the RestoreInProgress metadata state

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreidan andreidan merged commit 86cc49e into elastic:master Dec 22, 2020
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Dec 22, 2020
This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by
```
    cannot delete snapshot during a restore in progress
```

This adds a wait step after the tests that polls the repository status
until there are no snapshots.

(cherry picked from commit 86cc49e)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Dec 22, 2020
This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by
```
    cannot delete snapshot during a restore in progress
```

This adds a wait step after the tests that polls the repository status
until there are no snapshots.

(cherry picked from commit 86cc49e)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit that referenced this pull request Dec 22, 2020
This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by
```
    cannot delete snapshot during a restore in progress
```

This adds a wait step after the tests that polls the repository status
until there are no snapshots.

(cherry picked from commit 86cc49e)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit that referenced this pull request Dec 22, 2020
This attempts to fix the flakiness seen in some of the tests
that mount an index as searchable snapshot.
The flakiness was caused when attempting to wipe the cluster after
the test executed due to an exception caused by
```
    cannot delete snapshot during a restore in progress
```

This adds a wait step after the tests that polls the repository status
until there are no snapshots.

(cherry picked from commit 86cc49e)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SearchableSnapshotActionIT failures
3 participants