Skip to content

[Transform] finish backport: adapt versions to 7.11 #65961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hendrikmuhs
Copy link

finalize the integration of #65584

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@dimitris-athanasiou
Copy link
Contributor

When it comes to serialization, we could completely remove the version checks on master.

Also, you mention reenabling BWC tests in the PR title, but it doesn't seem like anything in the PR does that.

@hendrikmuhs
Copy link
Author

When it comes to serialization, we could completely remove the version checks on master.

some of the old ones, yes. But lets do that in 7.last.
Note, most of the version changes in this PR are not about serialization but about the version when the transform was created.

Also, you mention reenabling BWC tests in the PR title, but it doesn't seem like anything in the PR does that.

Not yet, working on it.

@hendrikmuhs hendrikmuhs changed the title [Transform] reenable bwc and adapt versions to 7.11 [Transform] finish backport: adapt versions to 7.11 Dec 7, 2020
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit 7dbe7c1 into elastic:master Dec 7, 2020
@hendrikmuhs hendrikmuhs deleted the transform-date-not-epoch-bwc-reenable branch December 7, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants