Refactor ActionListener#map towards Stricter API #65526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making `#map` look and feel a little nicer, optimize chains of `#map`, and replace `#delegateFailure` calls with `#map` calls where possible in order to enforce callbacks not throwing where possible.
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Dec 1, 2020
| return new MappedActionListener<>(fn, this); | ||
| } | ||
|
|
||
| final class MappedActionListener<Response, O> implements ActionListener<Response> { |
There was a problem hiding this comment.
Can we use a more descriptive type name than "O"?
|
Thanks Ryan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 1, 2020
Making `#map` look and feel a little nicer, optimize chains of `#map`, and replace `#delegateFailure` calls with `#map` calls where possible in order to enforce callbacks not throwing where possible.
original-brownbear
added a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
#maplook and feel a little nicer, optimize chains of#map,and replace
#delegateFailurecalls with#mapcalls where possiblein order to enforce callbacks not throwing where possible.