Skip to content

Docs: add known issue 65488 - SQL ignoring non-eq #65492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2020

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Nov 25, 2020

Add description of the #65488 as a known issue in the release notes.

Add description of the elastic#65488 known issue in release notes.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @bpintea! I left a suggestion that clarifies the language and adds an example. I'll take another look once that's resolved.

bpintea and others added 2 commits November 25, 2020 16:49
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Add the known issue under following releasesȘ
- 7.7.0 & .1
- 7.8.0 & .1
- 7.9.0 & .1 & .2 & .3
- 7.10.0
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for iterating on this @bpintea.

s/WHERE/`WHERE`
7.9.0 release had a "known issues" section already, place the SQL issue
under that one instead of opening a new one.
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 64ddf08 into elastic:7.10 Nov 26, 2020
@bpintea bpintea deleted the docs/known_issues_65488 branch November 26, 2020 10:43
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea
Copy link
Contributor Author

bpintea commented Nov 30, 2020

@jrodewig, I was about to backport this change, but then not sure if necessary or beneficial[*] since that "code" - i.e. the release notes in pre 7.10 branches - won't get used again anymore. Still, let me know please if the practice is to do so in these circumstances.

[*] ...as those branches will contain the note, but not the fix.

@jrodewig
Copy link
Contributor

@bpintea I think backporting only to 7.10 branches makes sense in that case. That approach also aligns with our docs backporting practices.

bpintea added a commit to bpintea/elasticsearch that referenced this pull request Nov 30, 2020
* Docs: add known issue 65488 - SQL ignoring non-eq

Add description of the elastic#65488 known issue in release notes.

(cherry picked from commit 64ddf08)
bpintea added a commit that referenced this pull request Nov 30, 2020
* Docs: add known issue 65488 - SQL ignoring non-eq

Add description of the #65488 known issue in release notes.

(cherry picked from commit 64ddf08)
jrodewig pushed a commit that referenced this pull request May 27, 2021
* Docs: add known issue 65488 - SQL ignoring non-eq

Add description of the #65488 known issue in release notes.
jrodewig pushed a commit that referenced this pull request May 27, 2021
* Docs: add known issue 65488 - SQL ignoring non-eq

Add description of the #65488 known issue in release notes.
jrodewig pushed a commit that referenced this pull request May 27, 2021
* Docs: add known issue 65488 - SQL ignoring non-eq

Add description of the #65488 known issue in release notes.
@jrodewig
Copy link
Contributor

jrodewig commented May 27, 2021

The docs team discussed our backport policy for known issues and decided to backport to any branch containing affected release notes. I backported this change to 7.9, 7.8, and 7.7. I also opened #73489 to clarify our backport policy.

@bpintea
Copy link
Contributor Author

bpintea commented May 27, 2021

thanks, @jrodewig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants