Clarify ingest-geoip database_file docs #64340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for the geoip processor database_file option appear to indicate that all geoip databases are in the config directory. This is leftover legacy from when this was the case when ingest-geoip was a plugin, but it is no longer true as the built-in databases now ship inside the ingest-geoip module that is bundled by default. This commit clarifies those docs.
jasontedor
added
>docs
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
Pinging @elastic/es-docs (>docs) |
elasticmachine
added
Team:Data Management
Adding further details to the description to increase visibility of the allowed filenames and extensions.
jakommo
approved these changes
Oct 29, 2020
jasontedor
added a commit
that referenced
this pull request
Oct 29, 2020
The docs for the geoip processor database_file option appear to indicate that all geoip databases are in the config directory. This is leftover legacy from when this was the case when ingest-geoip was a plugin, but it is no longer true as the built-in databases now ship inside the ingest-geoip module that is bundled by default. This commit clarifies those docs. Co-authored-by: Jakob Reiter <jakommo@users.noreply.github.com>
jasontedor
added a commit
that referenced
this pull request
Oct 29, 2020
The docs for the geoip processor database_file option appear to indicate that all geoip databases are in the config directory. This is leftover legacy from when this was the case when ingest-geoip was a plugin, but it is no longer true as the built-in databases now ship inside the ingest-geoip module that is bundled by default. This commit clarifies those docs. Co-authored-by: Jakob Reiter <jakommo@users.noreply.github.com>
|
@jakommo Thanks. Please take a look at the final change I merged and let me know if you have any concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for the geoip processor database_file option appear to indicate that all geoip databases are in the config directory. This is leftover legacy from when this was the case when ingest-geoip was a plugin, but it is no longer true as the built-in databases now ship inside the ingest-geoip module that is bundled by default. This commit clarifies those docs.
Closes #64203