Skip to content

Remove TypeFieldMapper #62838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2020

Conversation

romseygeek
Copy link
Contributor

We don't need a special TypeFieldMapper for anything in master; all access
to the type field can be done via a TypeFieldType that issues appropriate
deprecation warnings.

Relates to #41059

@romseygeek romseygeek added :Search Foundations/Mapping Index mappings, including merging and defining field types >refactoring v8.0.0 labels Sep 23, 2020
@romseygeek romseygeek self-assigned this Sep 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 23, 2020
@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romseygeek thanks, this PR LGTM. Just wanted to confirm with you that in 8.0 we still want to allow queries and aggs on _type field? Didn't we want to completely disallow this?

@romseygeek
Copy link
Contributor Author

Didn't we want to completely disallow this?

Yes, we'll disallow it in a follow up but I wanted to get the deprecations into master and 7x first.

@romseygeek romseygeek merged commit 981258b into elastic:master Sep 30, 2020
@romseygeek romseygeek deleted the types-removal/typefieldmapper branch September 30, 2020 14:47
@romseygeek
Copy link
Contributor Author

Hm, it looks like we can't actually backport this to 7x because the type field mapper is still used in various places, and the neat field type improvements don't work because the type itself is not necessarily known when then mapper is built. So we need to wait until 9x to remove things fully, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants