-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Remove TypeFieldMapper #62838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TypeFieldMapper #62838
Conversation
Pinging @elastic/es-search (:Search/Mapping) |
@elasticmachine run elasticsearch-ci/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romseygeek thanks, this PR LGTM. Just wanted to confirm with you that in 8.0 we still want to allow queries and aggs on _type field? Didn't we want to completely disallow this?
Yes, we'll disallow it in a follow up but I wanted to get the deprecations into master and 7x first. |
Hm, it looks like we can't actually backport this to 7x because the type field mapper is still used in various places, and the neat field type improvements don't work because the type itself is not necessarily known when then mapper is built. So we need to wait until 9x to remove things fully, unfortunately. |
We don't need a special TypeFieldMapper for anything in master; all access
to the type field can be done via a TypeFieldType that issues appropriate
deprecation warnings.
Relates to #41059