Skip to content

EQL: Remove support for = for comparisons #62756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Sep 22, 2020

Since = is rarely used and is undocumented we its support for
equality comparisons keeping == as the only option. = is now only
used for assignements like in maxspan=10m.

Closes: #62650

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 22, 2020
@matriv
Copy link
Contributor Author

matriv commented Sep 22, 2020

/cc @jrodewig I've checked the docs, (we don't document the = for comparisons) but it would be great if you could double check if any other change is needed. Thx!

@costin Should we mark it as breaking after all?

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin mentioned this pull request Sep 22, 2020
7 tasks
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since `=` is rarely used and is undocumented we its support for
equality comparisons keeping `==` as the only option. `=` is now only
used for assignements like in `maxspan=10m`.

Closes: elastic#62650
@matriv
Copy link
Contributor Author

matriv commented Sep 22, 2020

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@costin
Copy link
Member

costin commented Sep 22, 2020

Let's err on the safe side and mark it as such. In the unlikely case folks are using it, they'll want to know about it even for an experimental release.

@matriv
Copy link
Contributor Author

matriv commented Sep 22, 2020

@costin also agree with marking it "breaking".

@matriv matriv merged commit ad5ae4d into elastic:master Sep 22, 2020
@matriv matriv deleted the fix-62650 branch September 22, 2020 15:37
matriv added a commit that referenced this pull request Sep 22, 2020
Since `=` is rarely used and is undocumented we its support for
equality comparisons keeping `==` as the only option. `=` is now only
used for assignments like in `maxspan=10m`.

Closes: #62650
(cherry picked from commit ad5ae4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQL: Remove (was Deprecate) = in favor of == for equality checks
6 participants