-
Notifications
You must be signed in to change notification settings - Fork 25.3k
EQL: Remove support for =
for comparisons
#62756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-ql (:Query Languages/EQL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since `=` is rarely used and is undocumented we its support for equality comparisons keeping `==` as the only option. `=` is now only used for assignements like in `maxspan=10m`. Closes: elastic#62650
@elasticmachine run elasticsearch-ci/1 |
Let's err on the safe side and mark it as such. In the unlikely case folks are using it, they'll want to know about it even for an experimental release. |
@costin also agree with marking it "breaking". |
Since
=
is rarely used and is undocumented we its support forequality comparisons keeping
==
as the only option.=
is now onlyused for assignements like in
maxspan=10m
.Closes: #62650