Skip to content

[TEST] Core tests with runtime fields minor fix #62009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented Sep 4, 2020

Two dynamic templates get added per runtime type, while one is enough. Also one of the two for the keyword field was incorrect.

Two dynamic templates get add per runtime type, while one is enough. Also one of the two for the keyword field was incorrect.
@javanna javanna added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Sep 4, 2020
@javanna javanna requested a review from nik9000 September 4, 2020 20:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 4, 2020
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javanna javanna merged commit 1f2f49b into elastic:master Sep 5, 2020
@javanna
Copy link
Member Author

javanna commented Sep 5, 2020

Side note: I have applied these changes as part of the backport PR for runtime fields (#62015) for 7.x, so there won't be a specific backport commit for these but they will be in 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants