Write deprecation logs to a data stream #61966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#61484. Closes elastic#46106. Implement a new log4j appender for deprecation logging, in order to write logs to a dedicated data stream. This is controlled by a new setting, `cluster.deprecation_indexing.enabled`.
pugnascotia
added
>enhancement
:Core/Infra/Logging
martijnvg
reviewed
Sep 4, 2020
.../src/main/java/org/elasticsearch/xpack/deprecation/logging/DeprecationIndexingComponent.java
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
|
@pgomulka would you mind reviewing this backport, please? I was caught out by |
pgomulka
approved these changes
Sep 7, 2020
|
Note that these changes were removed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58924.
Closes #46106. Introduce a mechanism for writing deprecation logs to a data stream as well as to disk.
Test by running
./gradlew runand then:This implementation reworks deprecation logging to rely on log4j by introducing filters and appenders, and a custom log level. The existing
deprecationX-Pack plugin simply configures an extra appender to capture messages to an index. A "component" class manages most of the interface between the cluster and the appender.This approach can be extended for other types of logging, e.g. security by introducing further custom log levels.