Expand testing for field_caps and search across multiple indices #61836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tests around field_caps and search against multiple indices, where one index has some fields defined as runtime fields, while another index has the same fields defined as concrete fields. We want to make sure that as long as the data type matches, the two can integrate seamlessly.
javanna
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
|
run elasticsearch-ci/packaging-sample-windows |
|
Lgtm, but it might be a bit better if the runtime fields just load from
source. That way you can aggregate across both of them and they'll both
have values. I believe we don't have tests for that yet. It's pretty safe,
knowing how aggs and queries work now, but it'd be nice.
…On Wed, Sep 2, 2020, 06:46 Luca Cavanna ***@***.***> wrote:
run elasticsearch-ci/packaging-sample-windows
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#61836 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIVEMQ4SI4M64PVWDADSDYPBXANCNFSM4QSZ6JNA>
.
|
Ignore this bit. I didn't notice this morning that you'd added the fields to the |
nik9000
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests around field_caps and search against multiple indices, where one index has some fields defined as runtime fields, while another index has the same fields defined as concrete fields. We want to make sure that as long as the data type matches, the two can integrate seamlessly.
Relates to #59332