BACKPORT 7x Fix auditing of API Key authn without the owner realm name (#59470) #59521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9470) The `Authentication` object that gets built following an API Key authentication contains the realm name of the owner user that created the key (which is audited), but the specific field used for storing it changed in elastic#51305 . This PR makes it so that auditing tolerates an "unfound" realm name, so it doesn't throw an NPE, because the owner realm name is not found in the expected field. Closes elastic#59425
|
@elasticmachine run elasticsearch-ci/bwc |
|
Stalled by #59531 . |
Aha, the API key name was also added to authentication metadata with my PR #51305. It is not available for v6.8. Thanks for fixing it. |
remute test because bwc tests won't work
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
albertzaharovits
force-pushed
the
backport_7x_audit_log_null_realm_for_api_keys
branch
from
f685999 to
b158f7f
Compare
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
1 similar comment
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
albertzaharovits
deleted the
backport_7x_audit_log_null_realm_for_api_keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59470
The
Authenticationobject that gets built following an API Key authenticationcontains the realm name of the owner user that created the key (which is audited),
but the specific field used for storing it changed in #51305 .
This PR makes it so that auditing tolerates an "unfound" realm name, so it doesn't
throw an NPE, because the owner realm name is not found in the expected field.
Closes #59425