Update ICU Analyzer Documentation #59305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
Contributor
Author
|
I signed a CLA Agreement twice, once when making the PR and once when pinged by the bot. How can I remove the failing check? EDIT: Looks like commenting seems to have fixed the problem. |
Contributor
|
@elasticmachine test this please |
romseygeek
approved these changes
Jul 13, 2020
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
Looks like a straight typo when I added the docs, LGTM and thanks for fixing!
pugnascotia
pushed a commit
that referenced
this pull request
Jul 13, 2020
pugnascotia
pushed a commit
that referenced
this pull request
Jul 13, 2020
Contributor
Contributor
Author
|
Thank you for merging! Hopefully this helps someone else out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the
icu_analyzerfor a project I was working on, and was very confused why it was folding diacritical marks as well, so I read the source here, and it seems theicu_analyzeruses theICUFoldingFilterwhich corresponds to theicu_foldingtoken filter.This PR fixes the documentation so that others don't fall into the same trap I did.