Skip to content

Remove uid from translog delete operation #59101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

Remove uid from translog delete operation #59101

merged 1 commit into from
Jul 7, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 6, 2020

We stopped persisting the doctype in translog since #47229. We should also stop storing the uid as we can construct it from the single mapping doctype and the id.

Relates #47229

@dnhatn dnhatn added >non-issue :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Jul 6, 2020
@dnhatn dnhatn requested review from romseygeek and ywelsch July 6, 2020 20:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 6, 2020
romseygeek
romseygeek approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to try and collapse id and uid entirely? It seems confusing to have both now.

@dnhatn
Copy link
Member Author

dnhatn commented Jul 7, 2020

Do we want to try and collapse id and uid entirely? It seems confusing to have both now.

@romseygeek Thanks for reviewing. I will clean up the uid.

@dnhatn dnhatn merged commit 31a569a into elastic:master Jul 7, 2020
@dnhatn dnhatn deleted the remove-uid-translog-delete branch July 7, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees
No one assigned
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @romseygeek @jakelandis