Skip to content

Implement MSLE (MeanSquaredLogarithmicError) evaluation metric for regression analysis #58684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2020
Merged

Implement MSLE (MeanSquaredLogarithmicError) evaluation metric for regression analysis #58684

merged 3 commits into from
Jun 30, 2020

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jun 29, 2020 •
edited
Loading

This PR implements MSLE evaluation metric for regression analysis.

Additionally, this PR adds RegressionEvaluationIT integration tests class.

Closes #58682

@przemekwitek przemekwitek force-pushed the evaluation_loss_functions branch 5 times, most recently from a080f9c to e33ade4 Compare June 30, 2020 07:20
@przemekwitek przemekwitek changed the title [DRAFT] Implement MSLE (MeanSquaredLogarithmicError) evaluation metric for regression analysis Implement MSLE (MeanSquaredLogarithmicError) evaluation metric for regression analysis Jun 30, 2020
@przemekwitek przemekwitek removed the WIP label Jun 30, 2020
@przemekwitek przemekwitek marked this pull request as ready for review June 30, 2020 07:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

davidkyle
davidkyle approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

The bwc failure is due to #58722 (I hit the same problem)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

1 similar comment
@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

@przemekwitek przemekwitek force-pushed the evaluation_loss_functions branch from 0e65503 to eeb966a Compare June 30, 2020 09:56
@przemekwitek przemekwitek merged commit dfa0624 into elastic:master Jun 30, 2020
@przemekwitek przemekwitek deleted the evaluation_loss_functions branch June 30, 2020 11:06
@przemekwitek przemekwitek mentioned this pull request Jun 30, 2020
Merged
@valeriy42 valeriy42 self-requested a review June 30, 2020 11:51
przemekwitek added a commit that referenced this pull request Jun 30, 2020
@przemekwitek
[7.x] Implement MSLE (MeanSquaredLogarithmicError) evaluation metric …
9ea9b7b 
…for regression analysis (#58684) (#58731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

@valeriy42 valeriy42 Awaiting requested review from valeriy42

Assignees
No one assigned
Labels
>feature :ml Machine learning v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MSLE function for regression evaluation.
4 participants
@przemekwitek @elasticmachine @davidkyle @jakelandis