Adjust docs for voting config exclusions API #55006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#50836 we deprecated the existing voting config exclusions API and added a new one. This commit adjust the docs to match.
DaveCTurner
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
jrodewig
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
LGTM.
I wonder if this should be included in the 7.8 breaking changes?
https://www.elastic.co/guide/en/elasticsearch/reference/7.x/breaking-changes-7.8.html
|
Thanks @jrodewig. This isn't a breaking change in 7.8 (the previous API is still quietly supported albeit deprecated) but will be when it's removed in 8.0. |
DaveCTurner
added a commit
that referenced
this pull request
Apr 20, 2020
In #50836 we deprecated the existing voting config exclusions API and added a new one. This commit adjust the docs to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50836 we deprecated the existing voting config exclusions API and added a
new one. This commit adjust the docs to match.