Fix serialization bug in SearchableSnapshotsStatsResponse #54864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
commented
Apr 7, 2020
| import static org.elasticsearch.cluster.routing.TestShardRouting.newShardRouting; | ||
| import static org.hamcrest.CoreMatchers.equalTo; | ||
|
|
||
| public class SearchableSnapshotsStatsResponseTests extends ESTestCase { |
There was a problem hiding this comment.
We can't use AbstractBroadcastResponseTestCase here because it relies on XContent parsing. We can't use AbstractWireSerializingTestCase as it relies on object equality, which is not implemented by BroadcastResponse.
|
I'm not sure why CI did not catch this issue before. |
tlrx
deleted the
fix-missing-serialization-in-SearchableSnapshotsStatsResponse
branch
tlrx
added a commit
that referenced
this pull request
Apr 7, 2020
This is a backport of #54803 for 7.x. This pull request cherry picks the squashed commit from #54803 with the additional commits: 6f50c92 which adjusts master code to 7.x a114549 to mute a failing ILM test (#54818) 48cbca1 and 50186b2 that cleans up and fixes the previous test aae12bb that adds a missing feature flag (#54861) 6f330e3 that adds missing serialization bits (#54864) bf72c02 that adjust the version in YAML tests a51955f that adds some plumbing for the transport client used in integration tests Co-authored-by: David Turner <david.turner@elastic.co> Co-authored-by: Yannick Welsch <yannick@welsch.lu> Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchableSnapshotsStatsResponseis missing the serialization of the list ofSearchableSnapshotShardStats.