-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Added include_type_name in API spec for indices.exists #54863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezimuel thanks, the change looks good to me, wondering what the CI failures are about though.
Maybe its difficult running CI on those older branches? Will dig a bit...
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
@elasticmachine update branch |
@ezimuel I read your comment here do I understand correctly that the purpose of this PR is to go back and update the specs for 6.7 to include a missing bit that should have been there? Is this needed for any work or pending release by the clients team itself, or is this purely wanting to update the old specs for posterity? |
@mark-vieira I discovered this issue working on elastic/elasticsearch-perl#169 (comment), when I was working on elasticsearch-perl 6.8 release for the Perl client. The Perl client was not updated since 6.0 and I'm trying to fill the gap with new releases. |
So we are retroactively releasing Perl clients for each 6.x version? |
@mark-vieira I'm trying to fill the gap on the elasticsearch-perl client. I released 6.80 and I'm working to release soon 7.3 and hopefully the next minor 7.8. I'm doing this since I've a code generator in place that works until 7.4, when we changed the API specs. I need to update this generator in order to release the latest version. |
@ezimuel any idea what should happen with this PR? I'm just scanning some of my old issues and wonder if this can be closed or should be moved forward? |
@cbuescher I can close this PR since I managed the |
This PR adds the
include_type_name
in API6.7
specification forindices.exists
as discussed in #54292