Skip to content

Added include_type_name in API spec for indices.exists #54863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Apr 7, 2020

This PR adds the include_type_name in API 6.7 specification for indices.exists as discussed in #54292

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezimuel thanks, the change looks good to me, wondering what the CI failures are about though.
Maybe its difficult running CI on those older branches? Will dig a bit...

@cbuescher cbuescher added :Core/Infra/REST API REST infrastructure and utilities v6.7.3 labels Apr 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@cbuescher cbuescher self-assigned this Apr 7, 2020
@cbuescher
Copy link
Member

@elasticmachine update branch

@mark-vieira
Copy link
Contributor

@ezimuel I read your comment here do I understand correctly that the purpose of this PR is to go back and update the specs for 6.7 to include a missing bit that should have been there?

Is this needed for any work or pending release by the clients team itself, or is this purely wanting to update the old specs for posterity?

@ezimuel
Copy link
Contributor Author

ezimuel commented Apr 7, 2020

@mark-vieira I discovered this issue working on elastic/elasticsearch-perl#169 (comment), when I was working on elasticsearch-perl 6.8 release for the Perl client. The Perl client was not updated since 6.0 and I'm trying to fill the gap with new releases.

@mark-vieira
Copy link
Contributor

The Perl client was not updated since 6.0 and I'm trying to fill the gap with new releases.

So we are retroactively releasing Perl clients for each 6.x version?

@ezimuel
Copy link
Contributor Author

ezimuel commented Apr 23, 2020

@mark-vieira I'm trying to fill the gap on the elasticsearch-perl client. I released 6.80 and I'm working to release soon 7.3 and hopefully the next minor 7.8. I'm doing this since I've a code generator in place that works until 7.4, when we changed the API specs. I need to update this generator in order to release the latest version.

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@cbuescher
Copy link
Member

@ezimuel any idea what should happen with this PR? I'm just scanning some of my old issues and wonder if this can be closed or should be moved forward?

@ezimuel
Copy link
Contributor Author

ezimuel commented Oct 19, 2020

@cbuescher I can close this PR since I managed the include_type_name parameter myself. Thanks.

@ezimuel ezimuel closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team v6.7.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants