Fix a master->7.x serialization bug #54429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`master` wasn't sending `auto_date_histogram`'s `minimumIntervalExpression` over the wire to `7.x` nodes even though everything above `7.3` expected it. We never noticed this because we didn't have any yml tests for `auto_date_histogram` until I added some in elastic#54161. Closes elastic#54396
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
I've labeled this |
nik9000
commented
Mar 30, 2020
| @@ -110,20 +110,6 @@ | |||
|
|
|||
| private String minimumIntervalExpression; | |||
|
|
|||
| public String getMinimumIntervalExpression() { | |||
There was a problem hiding this comment.
I'm moving these below the ctor to make me feel better.
nik9000
commented
Mar 30, 2020
| @@ -138,6 +124,14 @@ public AutoDateHistogramAggregationBuilder(StreamInput in) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
I'm moving this up under the reading ctor so it is easier to compare.
nik9000
commented
Mar 30, 2020
| @Override | ||
| protected void innerWriteTo(StreamOutput out) throws IOException { | ||
| out.writeVInt(numBuckets); | ||
| if (out.getVersion().onOrAfter(Version.V_7_3_0)) { |
There was a problem hiding this comment.
Changing this from 8_0_0 to 7_3_0 is the actual fix.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 30, 2020
This fixes a serialization bug in `auto_date_histogram` that comes up in a cluster mixed between pre-7.3.0 and post-7.3.0. Includes elastic#54429 to keep 7.x looking like master for simpler backports. Closes elastic#54382
nik9000
added a commit
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterwasn't sendingauto_date_histogram'sminimumIntervalExpressionover the wire to7.xnodes even thougheverything above
7.3expected it. We never noticed this because wedidn't have any yml tests for
auto_date_histogramuntil I added somein #54161.
Closes #54396