Fix pipeline agg serialization for ccs #54282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pipeline aggregations used in cross cluster search from an older version of Elasticsearch to a newer version of Elasticsearch. I broke this in elastic#53730 when I was too aggressive in shutting off serialization of pipeline aggs. In particular, this comes up when the coordinating node is pre-7.8.0 and the gateway node is on or after 7.8.0. The fix is another step down the line to remove pipeline aggregators from the aggregation tree. Sort of. It create a new `List<PipelineAggregator>` member in `InternalAggregation` *but* it is only used for bwc serialization and it is fed by the mechanism established in elastic#53730 to read the pipelines from the
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
I've labeled this non-issue because it fixes a bug in an unreleased version. |
3 tasks
polyfractal
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
For posterity, we chatted about this offline, and while neither of us are stoked about the mutability aspect, it might be the least-bad option :) Nik might see if a decorator/wrapper thing is better as a followup, but it might not so this should be fine as we expect it to be mostly temporary.
👍
|
Thanks @polyfractal ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 30, 2020
This fixes pipeline aggregations used in cross cluster search from an older version of Elasticsearch to a newer version of Elasticsearch. I broke this in elastic#53730 when I was too aggressive in shutting off serialization of pipeline aggs. In particular, this comes up when the coordinating node is pre-7.8.0 and the gateway node is on or after 7.8.0. The fix is another step down the line to remove pipeline aggregators from the aggregation tree. Sort of. It create a new `List<PipelineAggregator>` member in `InternalAggregation` *but* it is only used for bwc serialization and it is fed by the mechanism established in elastic#53730 to read the pipelines from the
nik9000
added a commit
that referenced
this pull request
Apr 2, 2020
This fixes pipeline aggregations used in cross cluster search from an older version of Elasticsearch to a newer version of Elasticsearch. I broke this in #53730 when I was too aggressive in shutting off serialization of pipeline aggs. In particular, this comes up when the coordinating node is pre-7.8.0 and the gateway node is on or after 7.8.0. The fix is another step down the line to remove pipeline aggregators from the aggregation tree. Sort of. It create a new `List<PipelineAggregator>` member in `InternalAggregation` *but* it is only used for bwc serialization and it is fed by the mechanism established in #53730 to read the pipelines from the
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 2, 2020
…4282) (elastic#54468)" This reverts commit a5adac0. It causes some bwc tests to fail.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 2, 2020
I derped out on a last minute bug fix when backporting elastic#54282 and it only causes the tests to fail about half the time. So I didn't catch it until after merging. Great! This fixes it.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2020
I derped out on a last minute bug fix when backporting #54282 and it only causes the tests to fail about half the time. So I didn't catch it until after merging. Great! This fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pipeline aggregations used in cross cluster search from an older
version of Elasticsearch to a newer version of Elasticsearch. I broke
this in #53730 when I was too aggressive in shutting off serialization
of pipeline aggs. In particular, this comes up when the coordinating
node is pre-7.8.0 and the gateway node is on or after 7.8.0.
The fix is another step down the line to remove pipeline aggregators
from the aggregation tree. Sort of. It create a new
List<PipelineAggregator>member inInternalAggregationbut it isonly used for bwc serialization and it is fed by the mechanism
established in #53730 to read the pipelines from the