Skip to content

Remove setuid,setgid bits on all files in Docker image #51851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

pugnascotia
Copy link
Contributor

Add a step the docker build that removes the setuid and setgid bits on all files. This is a a very small partial backport from #50277.

This is to mitigate "stackclash" attacks. This is a a very small partial
backport from elastic#50277.
@pugnascotia pugnascotia added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.7.0 labels Feb 4, 2020
@pugnascotia pugnascotia requested a review from dliappis February 4, 2020 10:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@mieciu
Copy link
Contributor

mieciu commented Feb 4, 2020

Thanks a lot @pugnascotia !!

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you consider a test for it, or is it too complex?

@pugnascotia
Copy link
Contributor Author

@elasticmachine update branch

@pugnascotia
Copy link
Contributor Author

@elasticmachine update branch

@pugnascotia pugnascotia merged commit b0ad371 into elastic:7.x Feb 13, 2020
@pugnascotia pugnascotia deleted the remove-setxid-via-dockerfile branch February 13, 2020 12:18
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants