Fix corruption simulation in RecoveryFromGatewayIT #50921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we simulate a corruption by deleting the `segments_*` file in RecoveryFromGatewayIT#testStartedShardFoundIfStateNotYetProcessed. However we do not correctly detect this as a corruption thanks to an outstanding `NORELEASE` task in the Store, so this test fails. This commit temporarily adjusts how we corrupt the store in this test to ensure that it is detected.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we simulate a corruption by deleting the
segments_*file inRecoveryFromGatewayIT#testStartedShardFoundIfStateNotYetProcessed. However we
do not correctly detect this as a corruption thanks to an outstanding
NORELEASEtask in the Store, so this test fails.This commit temporarily adjusts how we corrupt the store in this test to ensure
that it is detected.