-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose cache setting in UserAgentPlugin #46533
Merged
spinscale
merged 4 commits into
elastic:master
from
spinscale:1909-expose-useragent-setting
Sep 16, 2019
Merged
Expose cache setting in UserAgentPlugin #46533
spinscale
merged 4 commits into
elastic:master
from
spinscale:1909-expose-useragent-setting
Sep 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting was not registered. Also documentation has been added.
Pinging @elastic/es-core-infra |
Pinging @elastic/es-core-features |
martijnvg
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/1 |
spinscale
added a commit
that referenced
this pull request
Sep 16, 2019
The setting was not registered. Also documentation has been added.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v7.5.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache size setting was not registered. Also documentation has been added.
Review note: I think merging to master/7.x is fine, please veto if you disagree.