Skip to content

[ML][Data Frame] adding breaking changes to doc #45051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2019

Conversation

benwtrent
Copy link
Member

Documenting the breaking change introduced in #43659

@benwtrent benwtrent added >docs General docs changes :ml/Transform Transform v7.4.0 v7.3.1 labels Jul 31, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@benwtrent
Copy link
Member Author

run elasticsearch-ci/docs

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@lcawl
Copy link
Contributor

lcawl commented Jul 31, 2019

@benwtrent This makes me wonder what happens to data frame transforms that already have that parameter specified. Do you think it's worth adding that detail?

@lcawl
Copy link
Contributor

lcawl commented Jul 31, 2019

NOTE: I've tagged this as a notable change so that it will appear in https://www.elastic.co/guide/en/elastic-stack/7.3/elasticsearch-breaking-changes.html when it's backported to the 7.3 branch. If you don't consider it to be notable, please just let me know.

@benwtrent
Copy link
Member Author

@lcawl I added a note that previous transforms will run, but the format will be ignored.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 2fc4b76 into elastic:7.x Aug 1, 2019
@benwtrent benwtrent deleted the doc/ml-df-add-breaking-changes branch August 1, 2019 12:30
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Aug 1, 2019
* [ML][Data Frame] adding breaking changes to doc

* [DOCS] Edits data frame transform breaking change

* Update migrate_7_3.asciidoc
benwtrent added a commit that referenced this pull request Aug 1, 2019
* [ML][Data Frame] adding breaking changes to doc

* [DOCS] Edits data frame transform breaking change

* Update migrate_7_3.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml/Transform Transform v7.3.1 v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants