Skip to content

[DOCS] Adds 7.3.0 ml-cpp release notes #45019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 30, 2019

This PR adds the PRs fromhttps://raw.githubusercontent.com/elastic/ml-cpp/7.3/docs/CHANGELOG.asciidoc to the Elasticsearch Reference 7.3.0 Release Notes.

It also edits the existing machine learning and data frame transform PRs.

@lcawl lcawl added >docs General docs changes :ml Machine learning v7.3.0 v7.4.0 labels Jul 30, 2019
@lcawl lcawl requested a review from droberts195 July 30, 2019 18:22
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

* [ML] Tag destination index with data frame metadata {pull}43567[#43567]
* [ML] Improve message when native controller cannot connect {pull}43565[#43565] (issue: {issue}42341[#42341])
* [ML] Introduce a setting for the process connect timeout {pull}43234[#43234]
* Tag destination index with data frame metadata {pull}43567[#43567]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this relates to data frame analytics, which is listed separately as a new feature, maybe this one shouldn't be included.

* [ML] Introduce a setting for the process connect timeout {pull}43234[#43234]
* Tag destination index with data frame metadata {pull}43567[#43567]
* Improve message when native controller cannot connect {pull}43565[#43565] (issue: {issue}42341[#42341])
* Introduce a setting for the process connect timeout {pull}43234[#43234]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was released in 6.8.2/7.2.1, so not sure if it needs including in 7.3.0 as well.

* [ML] Adding support for geo_shape, geo_centroid, geo_point in datafeeds {pull}42969[#42969] (issue: {issue}42820[#42820])
* [ML] Add earliest and latest timestamps to field stats {pull}42890[#42890]
* [ML] Change dots in CSV column names to underscores {pull}42839[#42839] (issue: {issue}26800[#26800])
* Restrict detection of epoch timestamps in find_file_structure {pull}43188[#43188]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About half the enhancements relate to the find_file_structure endpoint, but they're all mixed up with the other ML enhancements. I think it would be clearer to list them all at the end of the ML section, as find_file_structure won't necessarily be of interest to most ML users. (But you may think this is setting a dangerous precedent in terms of effort spent on organising the release notes, in which case I'm happy to leave the order random.)

* [ML] Change dots in CSV column names to underscores {pull}42839[#42839] (issue: {issue}26800[#26800])
* Restrict detection of epoch timestamps in find_file_structure {pull}43188[#43188]
* Adding support for geo_shape, geo_centroid, geo_point in datafeeds {pull}42969[#42969] (issue: {issue}42820[#42820])
* Add earliest and latest timestamps to field stats {pull}42890[#42890]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "in find_file_structure response"

* Restrict detection of epoch timestamps in find_file_structure {pull}43188[#43188]
* Adding support for geo_shape, geo_centroid, geo_point in datafeeds {pull}42969[#42969] (issue: {issue}42820[#42820])
* Add earliest and latest timestamps to field stats {pull}42890[#42890]
* Change dots in CSV column names to underscores {pull}42839[#42839] (issue: {issue}26800[#26800])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "in find_file_structure response"

@@ -355,10 +355,15 @@ Machine Learning::
* Fix test for old cluster version >= 7.3.0 {pull}44437[#44437]
* Use specific version constant for wire bwc check {pull}44316[#44316] (issue: {issue}42501[#42501])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced and fixed without ever being released, so I don't think it needs release noting.

* Wait for .ml-config primary before assigning persistent tasks {pull}44170[#44170] (issue: {issue}44156[#44156])
* Fix ML memory tracker lockup when inner step fails {pull}44158[#44158] (issue: {issue}44156[#44156])
* Fix datafeed checks when a concrete remote index is present {pull}43923[#43923] (issue: {issue}42113[#42113])
* Fix possible race condition when closing an opening job {pull}42506[#42506]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in 6.8.1/7.2.0 - does it need to be here too?

* [ML] Fix possible race condition when closing an opening job {pull}42506[#42506]
* Wait for .ml-config primary before assigning persistent tasks {pull}44170[#44170] (issue: {issue}44156[#44156])
* Fix ML memory tracker lockup when inner step fails {pull}44158[#44158] (issue: {issue}44156[#44156])
* Fix datafeed checks when a concrete remote index is present {pull}43923[#43923] (issue: {issue}42113[#42113])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in 6.8.2/7.2.1 - does it need to be here too?

* Adjusting error message {pull}43455[#43455]
* Size the GET stats search by number of Ids requested {pull}43206[#43206] (issue: {issue}43203[#43203])
* Rewrite start and stop to answer with acknowledged {pull}42589[#42589] (issue: {issue}42450[#42450])
* Set DF task state to stopped when stopping {pull}42516[#42516] (issue: {issue}42441[#42441])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "DF" abbreviation acceptable to use?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, "DF" seems superflous.

* Size the GET stats search by number of Ids requested {pull}43206[#43206] (issue: {issue}43203[#43203])
* Rewrite start and stop to answer with acknowledged {pull}42589[#42589] (issue: {issue}42450[#42450])
* Set DF task state to stopped when stopping {pull}42516[#42516] (issue: {issue}42441[#42441])
* Add support for fixed_interval, calendar_interval, remove interval {pull}42427[#42427] (issues: {issue}33727[#33727], {issue}42297[#42297])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This went into 7.2.0, which was when data frames was first released. From an end user's perspective data frame transforms have always been like this, so this item can be removed from the release notes.

* Adjusting error message {pull}43455[#43455]
* Size the GET stats search by number of Ids requested {pull}43206[#43206] (issue: {issue}43203[#43203])
* Rewrite start and stop to answer with acknowledged {pull}42589[#42589] (issue: {issue}42450[#42450])
* Set DF task state to stopped when stopping {pull}42516[#42516] (issue: {issue}42441[#42441])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, "DF" seems superflous.

* Data frame task failure do not make a 500 response {pull}44058[#44058] (issue: {issue}44011[#44011])
* Audit message missing for autostop {pull}43984[#43984] (issue: {issue}43977[#43977])
* Add data frame transform cluster privileges to HLRC {pull}43879[#43879]
* Fix progress measurement for continuous transforms {pull}43838[#43838]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this, progress is broken for continuous

@lcawl
Copy link
Contributor Author

lcawl commented Jul 31, 2019

Thanks for all the feedback, @droberts195 and @hendrikmuhs

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 7f74790 into elastic:7.x Aug 1, 2019
@lcawl lcawl deleted the ml-release-notes branch August 1, 2019 16:12
lcawl added a commit that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning v7.3.0 v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants