-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[DOCS] Fixes terms in HLRC data frame transform APIs #44838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-core-features |
Pinging @elastic/es-docs |
Pinging @elastic/ml-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming you're happy with the name of the anchor I asked about
@@ -564,12 +564,14 @@ include::ilm/lifecycle_management_status.asciidoc[] | |||
include::ilm/retry_lifecycle_policy.asciidoc[] | |||
include::ilm/remove_lifecycle_policy_from_index.asciidoc[] | |||
|
|||
== Data Frame APIs | |||
[[_data_frame_transform_apis]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this anchor supposed to start with an underscore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what it defaults to automatically at the moment. I think we'll want to ultimately change it, but didn't want to break any current bookmarks.
This PR updates the content in the Java REST Client > Java High Level REST Client > Data Frame APIs documentation (https://www.elastic.co/guide/en/elasticsearch/client/java-rest/master/_data_frame_apis.html) such that it uses appropriate attributes for the terminology.
It also fixes the titles to follow sentence style capitalization.