Skip to content

[DOCS] Fixes terms in HLRC data frame transform APIs #44838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 24, 2019

This PR updates the content in the Java REST Client > Java High Level REST Client > Data Frame APIs documentation (https://www.elastic.co/guide/en/elasticsearch/client/java-rest/master/_data_frame_apis.html) such that it uses appropriate attributes for the terminology.

It also fixes the titles to follow sentence style capitalization.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you're happy with the name of the anchor I asked about

@@ -564,12 +564,14 @@ include::ilm/lifecycle_management_status.asciidoc[]
include::ilm/retry_lifecycle_policy.asciidoc[]
include::ilm/remove_lifecycle_policy_from_index.asciidoc[]

== Data Frame APIs
[[_data_frame_transform_apis]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this anchor supposed to start with an underscore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what it defaults to automatically at the moment. I think we'll want to ultimately change it, but didn't want to break any current bookmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants