-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Implement exponential average search time per hour statistics. #44683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
przemekwitek
merged 3 commits into
elastic:master
from
przemekwitek:exponential_average
Jul 26, 2019
Merged
Implement exponential average search time per hour statistics. #44683
przemekwitek
merged 3 commits into
elastic:master
from
przemekwitek:exponential_average
Jul 26, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38106fd
to
d1b5a38
Compare
Pinging @elastic/ml-core |
d1b5a38
to
2c533ac
Compare
davidkyle
reviewed
Jul 22, 2019
...rc/main/java/org/elasticsearch/xpack/core/ml/utils/ExponentialAverageCalculationContext.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Jul 23, 2019
.../plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/persistence/TimingStatsReporter.java
Outdated
Show resolved
Hide resolved
ce91e16
to
345042f
Compare
davidkyle
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f97482
to
f7fef25
Compare
run elasticsearch-ci/1 |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 26, 2019
przemekwitek
added a commit
that referenced
this pull request
Jul 26, 2019
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new fields:
These fields implement exponential moving average calculation. They are directly comparable to each other giving the user the idea whether the job spends more time searching or performing end-of-bucket processing.
Related to #29857