Skip to content

[TEST] Fix testCollectNodes #43970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jul 4, 2019

The test fails as it can interact with other tests (see explanation at #41067 (comment)).

It is fixed by giving unique cluster names to each remote cluster. As RemoteClusterConnection is sticky to the remote cluster name (see RemoteClusterConnection.remoteClusterName), this should prevent the test from connecting to nodes of other tests with different cluster name.

Also reverts a commit (8a1a000) that was added to increase log levels.

Closes #41067

@ywelsch ywelsch added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations v8.0.0 v7.3.0 v7.4.0 labels Jul 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch requested a review from henningandersen July 4, 2019 10:53
@ywelsch
Copy link
Contributor Author

ywelsch commented Jul 4, 2019

@elasticmachine run elasticsearch-ci/1

@ywelsch
Copy link
Contributor Author

ywelsch commented Jul 4, 2019

superseded by #43983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteClusterServiceTests#testCollectNodes failure
2 participants