Amend prepareIndexIfNeededThenExecute for security token refresh
#41697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security |
|
The 7.x cherry-pick has been incorporated in the backport #41673 (which contains the tests for the fix). |
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 1, 2019
) This fixes a low level bug that manifests, in certain circumstances, by the failure of the refresh operation. Version 7.1 added a new `superseded_by` field to the `.security` index mapping. This field is used when indexing a refresh operation (a document update). Because the document update was not guarded by the obligatory `prepareIndexIfNeededThenExecute` the refresh operation would fail if it were the first operation when the cluster was upgraded from a version < 7.1 . This failure was catched (and fails reliably) in the backport elastic#41673 .
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
) This fixes a low level bug that manifests, in certain circumstances, by the failure of the refresh operation. Version 7.1 added a new `superseded_by` field to the `.security` index mapping. This field is used when indexing a refresh operation (a document update). Because the document update was not guarded by the obligatory `prepareIndexIfNeededThenExecute` the refresh operation would fail if it were the first operation when the cluster was upgraded from a version < 7.1 . This failure was catched (and fails reliably) in the backport elastic#41673 .
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
) This fixes a low level bug that manifests, in certain circumstances, by the failure of the refresh operation. Version 7.1 added a new `superseded_by` field to the `.security` index mapping. This field is used when indexing a refresh operation (a document update). Because the document update was not guarded by the obligatory `prepareIndexIfNeededThenExecute` the refresh operation would fail if it were the first operation when the cluster was upgraded from a version < 7.1 . This failure was catched (and fails reliably) in the backport elastic#41673 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a low level bug that manifests by the failure of the refresh operation, in certain circumstances.
Version 7.1 added a new
superseded_byfield to the.securityindex mapping.This field is used when indexing a refresh operation (a document update).
Because the document update was not guarded by the obligatory
prepareIndexIfNeededThenExecutethe refresh operation would fail if it were the first operation when the cluster was upgraded from a version < 7.1 .This failure was catched (and fails reliably) in the backport #41673 . See: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/4695/