Rejection of Port Ranges in module discovery.seed_hosts

server/src/main/java/org/elasticsearch/discovery/SettingsBasedSeedHostsProvider.java

@@ -54,11 +54,13 @@ public class SettingsBasedSeedHostsProvider implements SeedHostsProvider {
     private final List<String> configuredHosts;
     private final int limitPortCounts;
 
+
     public SettingsBasedSeedHostsProvider(Settings settings, TransportService transportService) {
         if (DISCOVERY_SEED_HOSTS_SETTING.exists(settings)) {
             configuredHosts = DISCOVERY_SEED_HOSTS_SETTING.get(settings);
             // we only limit to 1 address, makes no sense to ping 100 ports
             limitPortCounts = LIMIT_FOREIGN_PORTS_COUNT;
+            checkInvalidPorts(configuredHosts);
         } else {
             // if unicast hosts are not specified, fill with simple defaults on the local machine
             configuredHosts = transportService.getLocalAddresses();
@@ -68,6 +70,15 @@ public SettingsBasedSeedHostsProvider(Settings settings, TransportService transp
         logger.debug("using initial hosts {}", configuredHosts);
     }
 
+    public void checkInvalidPorts(List<String> configuredHosts) {
+        for (String host : configuredHosts) {
+            if (host.contains("-")) {
+                throw new IllegalArgumentException("Configuration Setting discovery.seed_hosts does not support a range of ports, [" +
+                                                    host + "] was found in provided seed hosts");
+            }
+        }
+    }
+
     @Override
     public List<TransportAddress> getSeedAddresses(HostsResolver hostsResolver) {
         return hostsResolver.resolveHosts(configuredHosts, limitPortCounts);

server/src/test/java/org/elasticsearch/discovery/SettingsBasedSeedHostsProviderTests.java

@@ -74,4 +74,28 @@ public void testGetsHostsFromSetting() {
             .build(), null).getSeedAddresses(hostsResolver);
         assertTrue(hostsResolver.getResolvedHosts());
     }
+
+    public void testExceptionOnPortRange() {
+        boolean exceptionThrown = false;
+        try {
+            new SettingsBasedSeedHostsProvider(Settings.builder()
+                .putList(SettingsBasedSeedHostsProvider.DISCOVERY_SEED_HOSTS_SETTING.getKey(), "localhost:9200-9300")
+                .build(), null);
+        } catch (IllegalArgumentException e) {
+            exceptionThrown = true;
+        }
+        assertTrue(exceptionThrown);
+    }
+
+    public void testSeedWithoutPortRange() {
+        boolean exceptionThrown = false;
+        try {
+            new SettingsBasedSeedHostsProvider(Settings.builder()
+                .putList(SettingsBasedSeedHostsProvider.DISCOVERY_SEED_HOSTS_SETTING.getKey(), "localhost:9200")
+                .build(), null);
+        } catch (Exception e) {
+            exceptionThrown = true;
+        }
+        assertFalse(exceptionThrown);
+    }
 }