Fix order of request body search parameter names #40777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order was random, which made it super hard to find anything. This changes the order to be alphabetically.
|
Pinging @elastic/es-docs |
jrodewig
reviewed
Apr 4, 2019
| @@ -188,46 +188,48 @@ to the client. This means it includes the time spent waiting in thread pools, | |||
| executing a distributed search across the whole cluster and gathering all the | |||
| results. | |||
|
|
|||
| include::request/query.asciidoc[] | |||
There was a problem hiding this comment.
Thanks for the PR! I agree that these parameters need a reorganization.
Not blocking, but I wonder if there is some value in leaving basic or commonly used parameters, like query or sort near the top.
It seems like a pertinent question is "how are users currently accessing these parameter pages?" I don't currently have access to Google Analytics or web analytics data (working on it), but that might give us an indicator.
That said, I'm good with proceeding if others are.
jrodewig
approved these changes
Apr 9, 2019
spinscale
added a commit
that referenced
this pull request
Apr 9, 2019
…0777) The order was random, which made it super hard to find anything. This changes the order to be alphabetically.
spinscale
added a commit
that referenced
this pull request
Apr 9, 2019
…0777) The order was random, which made it super hard to find anything. This changes the order to be alphabetically.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 9, 2019
…forced-unsafe-publication * elastic/master: Improve Watcher test framework resiliency (elastic#40658) Fix order of request body search parameter names in documentation (elastic#40777) Node repurpose tool docs (elastic#40525) [Docs] Delete explanation for completion suggester default analyzer choice (elastic#36720) Revert "Revert "Change HLRC CCR response tests to use AbstractResponseTestCase base class. (elastic#40257)"" (elastic#40971) Short-circuit rebalancing when disabled (elastic#40966)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…astic#40777) The order was random, which made it super hard to find anything. This changes the order to be alphabetically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order was random, which made it super hard to find anything. This
changes the order to be alphabetically.
Current on the docs website:
With this