Increase suite timeout to 30 minutes for docs tests #40521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT`. As far as I can see, the docs tests are taking quite a while, I assume it's because more and more docs snippets get added over time, which means more tests. The current suite timeout is the default 20 minutes. It takes me just a little less than 20 minutes to run these on my laptop. On my CI, I end up hitting the suite timeout. Hereby I propose that we increase the suite timeout to 30 minutes.
javanna
added
>test
|
Pinging @elastic/es-core-infra |
|
I think increasing to 30m is okay, but if we need to go any further we should investigate why these are taking so long rather than increasing the timeout even more. I suspect there is some environmental factor that we have not considered yet. I say this because these tests take 14m on my machine. |
|
agreed @jasontedor that was my thinking too. |
jasontedor
reviewed
Mar 27, 2019
|
|
||
| @TimeoutSuite(millis = 30 * TimeUnits.MINUTE) |
There was a problem hiding this comment.
Can you leave a comment here summarizing our current thinking on this timeout value?
There was a problem hiding this comment.
Something like "The default 20 minutes timeout is not always enough, please do not increase further than 30 minutes without analyzing what makes these tests so slow" ?
There was a problem hiding this comment.
Yeah, something like that indeed. 😄
jasontedor
approved these changes
Mar 27, 2019
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 29, 2019
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT` As far as I can see, the docs tests are taking quite a while, I assume it's because more and more docs snippets get added over time, which means more tests. The current suite timeout is the default 20 minutes. It takes me just a little less than 20 minutes to run these on my laptop. On my CI, I end up hitting the suite timeout. Hereby I propose that we increase the suite timeout to 30 minutes.
javanna
added a commit
that referenced
this pull request
Mar 29, 2019
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT` As far as I can see, the docs tests are taking quite a while, I assume it's because more and more docs snippets get added over time, which means more tests. The current suite timeout is the default 20 minutes. It takes me just a little less than 20 minutes to run these on my laptop. On my CI, I end up hitting the suite timeout. Hereby I propose that we increase the suite timeout to 30 minutes.
javanna
added a commit
that referenced
this pull request
Mar 29, 2019
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT` As far as I can see, the docs tests are taking quite a while, I assume it's because more and more docs snippets get added over time, which means more tests. The current suite timeout is the default 20 minutes. It takes me just a little less than 20 minutes to run these on my laptop. On my CI, I end up hitting the suite timeout. Hereby I propose that we increase the suite timeout to 30 minutes.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 1, 2019
* elastic/7.0: [TEST] Mute WebhookHttpsIntegrationTests.testHttps [DOCS] Add 'time value' links to several monitor settings (elastic#40633) (elastic#40687) Do not perform cleanup if Manifest write fails with dirty exception (elastic#40519) Remove mention of soft deletes from getting started (elastic#40668) Fix bug in detecting use of bundled JDK on macOS Reindex conflicts clarification (docs) (elastic#40442) SQL: [Tests] Enable integration tests for fixed issues (elastic#40664) Add information about the default sort mode (elastic#40657) SQL: [Docs] Fix example for CURDATE SQL: [Docs] Fix doc errors regarding CURRENT_DATE. (elastic#40649) Clarify using time_zone and date math in range query (elastic#40655) Add notice for bundled jdk (elastic#40576) disable kerberos test until kerberos fixture is working again [DOCS] Use "source" instead of "inline" in ML docs (elastic#40635) Unmute and fix testSubParserArray (elastic#40626) Geo Point parse error fix (elastic#40447) Increase suite timeout to 30 minutes for docs tests (elastic#40521) Fix repository-hdfs when no docker and unnecesary fixture Avoid building hdfs-fixure use an image that works instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been hitting the suite timeout on
DocsClientYamlTestSuiteIT.As far as I can see, the docs tests are taking quite a while, I assume
it's because more and more docs snippets get added over time, which
means more tests. The current suite timeout is the default 20 minutes.
It takes me just a little less than 20 minutes to run these on my
laptop. On my CI, I end up hitting the suite timeout. Hereby I propose
that we increase the suite timeout to 30 minutes.