Skip to content

Remove es.cluster_state.size hard failure #40111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jasontedor
Copy link
Member

In 6.7.0 we introduced a system property to return the old behavior of
computing and sending the compressed size of the cluster state on
cluster state endpoints. In 7.0.0, we removed this behavior but hard
failed usage of this system property (to clearly inform users this
behavior is gone). In this commit, intending to target 8.0.0 only, we
remove this detection as it should no longer be needed; that is, we now
treat this as dead code.

Relates #39806
Relates #39827
Relates #39951
Relates #40016
Relates #40061

In 6.7.0 we introduced a system property to return the old behavior of
computing and sending the compressed size of the cluster state on
cluster state endpoints. In 7.0.0, we removed this behavior but hard
failed usage of this system property (to clearly inform users this
behavior is gone). In this commit, intending to target 8.0.0 only, we
remove this detection as it should no longer be needed; that is, we now
treat this as dead code.
@jasontedor jasontedor added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.0.0 labels Mar 15, 2019
@jasontedor jasontedor requested a review from DaveCTurner March 15, 2019 17:29
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…te-size-hard-failure

* elastic/master:
  use shell with JAVA_HOME for starting archive (elastic#40118)
  Remove Migration Upgrade and Assistance APIs (elastic#40075)
  Revert "Fix IndexSearcherWrapper visibility (elastic#39071)"
  Remove transport name from tcp channel (elastic#40074)
  Document the limitation around field aliases and percolator. (elastic#40073)
  SQL: Refactor Literals serialization method (elastic#40058)
@jasontedor jasontedor merged commit 87627fc into elastic:master Mar 16, 2019
@jasontedor jasontedor deleted the remove-cluster-state-size-hard-failure branch March 16, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >non-issue v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants