Better error messages when pipelines reference incompatible aggs #40068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipelines require single-valued agg or a numeric to be returned. If they don't get that, they throw an exception. Unfortunately, this exception text is very confusing to users because it usually arises from pathing "through" multiple terms aggs. The final target is a numeric, but it's the intermediary aggs that cause the problem. This commit adds the current agg name to the exception message so the user knows which "level" is the issue.
|
Pinging @elastic/es-analytics-geo |
iverase
reviewed
Apr 4, 2019
server/src/main/java/org/elasticsearch/search/aggregations/pipeline/BucketHelpers.java
Outdated
Show resolved
Hide resolved
|
<3 |
|
@elasticmachine run elasticsearch-ci/packaging-sample please |
polyfractal
added a commit
that referenced
this pull request
Apr 15, 2019
) Pipelines require single-valued agg or a numeric to be returned. If they don't get that, they throw an exception. Unfortunately, this exception text is very confusing to users because it usually arises from pathing "through" multiple terms aggs. The final target is a numeric, but it's the intermediary aggs that cause the problem. This commit adds the current agg name to the exception message so the user knows which "level" is the issue.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…stic#40068) Pipelines require single-valued agg or a numeric to be returned. If they don't get that, they throw an exception. Unfortunately, this exception text is very confusing to users because it usually arises from pathing "through" multiple terms aggs. The final target is a numeric, but it's the intermediary aggs that cause the problem. This commit adds the current agg name to the exception message so the user knows which "level" is the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a less-invasive reboot of #30152.
Pipeline aggs need a numeric value, or a single-valued agg to work properly. If they reference multi-valued aggs or anything else, they throw a rather cryptic error. This PR, like #30152, attempts to make the error nicer.
Unlike the previous attempt, this is much less invasive. It tries to see if the current problematic object is a
MultiValueagg and then provides some helpful text. Otherwise, it throws an exception like before but now includes the aggregation name so the user can help determine which "level" of the path went bad.Closes #25273