-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Remove missing waitSeconds variable from error message #39321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-core-infra |
alpar-t
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem.
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem.
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem.
This was referenced Feb 28, 2019
jbaiera
added a commit
that referenced
this pull request
Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem. Backports #39321
jbaiera
added a commit
that referenced
this pull request
Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem. Backports #39321
jbaiera
added a commit
that referenced
this pull request
Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. An exception throw was added if this were to time out instead of failing with no information, but the exception text uses a missing variable which further obfuscates the problem. Backports #39321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v6.7.0
v7.0.0-rc1
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. #37574 added an exception throw if this were to time out instead of failing with no information, but
the exception text uses a missing variable which further obfuscates the problem.