Skip to content

Remove missing waitSeconds variable from error message #39321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Feb 22, 2019

When test clusters are stood up, one of the steps in the wait task is to wait for ports files to appear. #37574 added an exception throw if this were to time out instead of failing with no information, but
the exception text uses a missing variable which further obfuscates the problem.

@jbaiera jbaiera added >non-issue :Delivery/Build Build or test infrastructure labels Feb 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaiera jbaiera merged commit 99f1a1f into elastic:master Feb 28, 2019
@jbaiera jbaiera deleted the fix-cluster-wait-seconds-var branch February 28, 2019 18:40
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Feb 28, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.
jbaiera added a commit that referenced this pull request Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.

Backports #39321
jbaiera added a commit that referenced this pull request Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.

Backports #39321
jbaiera added a commit that referenced this pull request Mar 1, 2019
When test clusters are stood up, one of the steps in the wait task is to wait for 
ports files to appear. An exception throw was added if this were to time out
instead of failing with no information, but the exception text uses a missing 
variable which further obfuscates the problem.

Backports #39321
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants